QF-1414-Download and writing data to a temporary file in QFieldCloudProjects. #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 35ace08: arm64-android |
nirvn
reviewed
Dec 20, 2024
suricactus
reviewed
Dec 21, 2024
mohsenD98
changed the title
suricactus
reviewed
Dec 21, 2024
suricactus
reviewed
Dec 27, 2024
Incrementally saving downloaded data to a temporary file during each progress update.
1- Allow changing tabs ["My Projects" / "Community"]. 2- Fix invisible progressBar under headersection (layer name). 3- Fix spacing between progressBar and next item.
mohsenD98
force-pushed
the
QField-Cloud-Projects
branch
from
abca708 to
74497ad
Compare
|
@suricactus , are you happy with this? |
suricactus
approved these changes
Dec 29, 2024
mohsenD98
changed the title
nirvn
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR aims to handle the download progress of a network reply by writing the downloaded data incrementally to a temporary file. The key steps include:
Listening to Download Progress: We connect the
downloadProgresssignal of theNetworkReplyto a lambda function that processes the download as it progresses.File Writing: Inside the lambda, we open the temporary file in append mode
(QIODevice::Append)and write the data to it each time new bytes are received.Error Handling: If any error occurs while opening the file or during the write operation, we log the error and abort the network reply
(rawReply->abort()).Reading Data: For each progress update, we read all available data from the reply using
readAll()and write it to the file.Ui polish:
Summary:
This approach focuses on incrementally saving downloaded data to a temporary file during each progress update. It includes basic error handling and attempts to append data to the file as it is received.